add toolbar to semantic style hooks - #34840
Merged
Mitch-At-Work merged 2 commits intoJul 17, 2025
Merged
Conversation
|
Pull request demo site: URL |
Rachel Yoo (rachethecreator)
force-pushed
the
ryoo/toolbar-semantic-tokens
branch
from
July 16, 2025 15:48
34863f8 to
1066d9c
Compare
Mitch-At-Work
requested changes
Jul 17, 2025
Mitch-At-Work
left a comment
Mitch-At-Work
left a comment
Contributor
There was a problem hiding this comment.
Just need to update these to use the semantic style hooks internally so that all non-toggle items follow semantic schema
Rachel Yoo (rachethecreator)
force-pushed
the
ryoo/toolbar-semantic-tokens
branch
from
July 17, 2025 18:16
1066d9c to
3219694
Compare
Mitch-At-Work
approved these changes
Jul 17, 2025
Mitch-At-Work
merged commit Jul 17, 2025
1440974
into
microsoft:extended-tokens
10 of 14 checks passed
Mitch-At-Work
pushed a commit
that referenced
this pull request
Aug 6, 2025
Mitch-At-Work
pushed a commit
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Toolbar to Semantic Style Hooks
Same gaps as Toggle Button for Toolbar Radio & Toggle Button
Lacking some vertical spacing/padding semantic tokens